Skip to content

refactor(spider-storage): Replace DashMap with tokio::sync::RwLock<HashMap> in JobCache to avoid holding shard locks across .await. - #321

Merged
sitaowang1998 merged 1 commit into
y-scope:storage-service-devfrom
LinZhihao-723:replace-dashmap
May 12, 2026
Merged

refactor(spider-storage): Replace DashMap with tokio::sync::RwLock<HashMap> in JobCache to avoid holding shard locks across .await.#321
sitaowang1998 merged 1 commit into
y-scope:storage-service-devfrom
LinZhihao-723:replace-dashmap

Conversation

@LinZhihao-723

@LinZhihao-723 LinZhihao-723 commented May 11, 2026

Copy link
Copy Markdown
Member

Description

As the title suggests.

Checklist

  • The PR satisfies the contribution guidelines.
  • This is a breaking change and that has been indicated in the PR title, OR this isn't a
    breaking change.
  • Necessary docs have been updated, OR no docs need to be updated.

Validation performed

  • Ensure all workflows pass.

@LinZhihao-723
LinZhihao-723 requested review from a team and sitaowang1998 as code owners May 11, 2026 23:16
@coderabbitai

coderabbitai Bot commented May 11, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 78632854-b686-423c-b984-431c5b10ec39

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sitaowang1998
sitaowang1998 merged commit fab4411 into y-scope:storage-service-dev May 12, 2026
11 checks passed
@LinZhihao-723 LinZhihao-723 mentioned this pull request Jun 15, 2026
Merged
4 tasks
LinZhihao-723 added a commit that referenced this pull request Jun 15, 2026
@LinZhihao-723 @sitaowang1998
feat(spider-storage): Merge storage-service-dev branch into main. (#…
1d1782b 
…343)

Related PRs: #319, #321, #322, #323, #324, #338, #339, #341.
Co-authored-by: sitaowang1998 <sitaowang1998@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sitaowang1998 sitaowang1998 sitaowang1998 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LinZhihao-723 @sitaowang1998